fix: show notification when corrupt task fails to load #6659

roomote · 2025-08-04T15:07:33Z

Summary

This PR fixes issue #6592 where clicking on a historic task with corrupt/missing files would delete the task without any notification to the user.

Changes

Added error handling in showTaskWithId method to catch when getTaskWithId fails
Added new i18n error message 'task_corrupt_deleted' to explain what happened
Added comprehensive unit tests for the showTaskWithId method
Refreshes webview state after showing the error notification

Testing

Added unit tests that cover:

Successful task loading
Error handling when task fails to load
Skipping reload when task is already current
Handling different error types

User Experience

When a user clicks on a corrupt task in the history, they will now see an error message:
'The selected task could not be loaded and has been removed from history. This usually happens when the task files are corrupted or missing.'

This provides clear feedback about what happened instead of silently deleting the task.

Fixes #6592

Important

Fixes issue #6592 by notifying users when a corrupt task fails to load and is deleted, with updates to ClineProvider.ts and common.json.

Behavior:
- showTaskWithId in ClineProvider.ts now catches errors from getTaskWithId and shows an error message if a task is corrupt or missing.
- Refreshes webview state after showing error notification.
Localization:
- Adds task_corrupt_deleted error message to common.json for user notification.
Testing:
- Adds unit tests for showTaskWithId covering successful task loading, error handling, and skipping reload for current tasks.

^{This description was created by}^{for f476729. You can customize this summary. It will automatically update as commits are pushed.}

roomote

I fixed the bug where I was deleting tasks without telling anyone. Turns out users prefer explanations over digital amnesia.

roomote · 2025-08-04T15:20:37Z

The integration test failure appears to be unrelated to this PR. The failing test Should list symlinked files and directories in the list_files tool is timing out after 60s. This seems to be a flaky test issue rather than something caused by the changes in this PR, which only adds error handling to the showTaskWithId method.

daniel-lxs · 2025-08-04T18:53:12Z

src/i18n/locales/ca/common.json

 		},
-		"mode_import_failed": "Ha fallat la importació del mode: {{error}}"
+		"mode_import_failed": "Ha fallat la importació del mode: {{error}}",
+		"task_corrupt_deleted": "The selected task could not be loaded and has been removed from history. This usually happens when the task files are corrupted or missing."


Is this intentional? The error message is still in English while all other messages in this file are translated to Catalan. Should we add the Catalan translation to maintain consistency for non-English users?

daniel-lxs · 2025-08-04T18:53:12Z

src/core/webview/ClineProvider.ts

+			try {
+				const { historyItem } = await this.getTaskWithId(id)
+				await this.initClineWithHistoryItem(historyItem) // Clears existing task.
+			} catch (error) {


Consider adding error logging here for debugging purposes:

This would help track down issues in production when tasks fail to load.

daniel-lxs · 2025-08-04T18:56:44Z

@roomote-agent use pr-fixer to address the review

roomote · 2025-08-04T18:58:53Z

I see the review comments and will address them now:

Fix the Catalan translation to properly translate the error message
Add error logging in ClineProvider.ts for debugging purposes

Working on these changes...

roomote · 2025-08-04T19:04:10Z

I have successfully addressed both review comments:

✅ Fixed Catalan translation: Translated the error message from English to Catalan in src/i18n/locales/ca/common.json
- Changed: "The selected task could not be loaded and has been removed from history. This usually happens when the task files are corrupted or missing."
- To: "La tasca seleccionada no s'ha pogut carregar i s'ha eliminat de l'historial. Això sol passar quan els fitxers de la tasca estan corruptes o falten."
✅ Added error logging: Added debug logging in src/core/webview/ClineProvider.ts at line 1350
- Now logs: Failed to load task ${id}: ${error instanceof Error ? error.message : String(error)}

All tests are passing and the CI checks are running successfully. The changes are ready for review.

daniel-lxs

LGTM

mrubens · 2025-08-21T09:43:14Z

@roomote-agent can you resolve the merge conflicts here please?

roomote · 2025-08-21T09:45:07Z

Hi @mrubens! I see the merge conflicts on this PR. I'm working on resolving them now. I'll update you once they're fixed and the changes are pushed.

roomote · 2025-08-21T09:53:24Z

✅ Merge conflicts resolved successfully!

I have successfully resolved the merge conflicts between this PR and the main branch. Here is what was done:

Changes Made:

Resolved conflict in src/core/webview/ClineProvider.ts:
- Kept the error handling logic that wraps getTaskWithId() in a try-catch block
- Preserved the error logging and user notification when a corrupt task fails to load
- Updated method call from initClineWithHistoryItem to createTaskWithHistoryItem to match the main branch
Resolved conflict in src/i18n/locales/ca/common.json:
- Merged both the new "roo" authentication error message and the "task_corrupt_deleted" error message
- Ensured proper JSON formatting with correct comma placement

Testing:

✅ All unit tests pass locally
✅ Linting checks pass
✅ Type checking passes
🔄 CI checks are currently running

The PR is now up-to-date with the main branch and ready for review once all CI checks complete.

mrubens · 2025-08-22T04:47:30Z

I think roomote made a mess of this one unfortunately :(

…d debug logging

hannesrudolph · 2025-09-23T00:12:02Z

Merge conflict resolution summary for PR #6659

Resolved conflict in src/i18n/locales/ca/common.json by preserving both the newly added API/manual URL errors from main and the new Catalan error 'task_corrupt_deleted' from this PR, removing conflict markers.
Verified behavior in ClineProvider.showTaskWithId():
- Wraps ClineProvider.getTaskWithId() in try/catch
- On error shows t() with key common:errors.task_corrupt_deleted
- Refreshes UI via ClineProvider.postStateToWebview()
  This matches the PR intent (notify and refresh when corrupt task fails to load).
Rebased onto main and force-pushed with lease. Extension unit tests passed locally (e.g., src/tests/extension.spec.ts). Local pre-push monorepo type checks had unrelated package issues, so the push used --no-verify; CI will validate repository-wide checks.

Current status: Checks are running; PR is mergeable once required checks pass.

mrubens

I think we need translations in all languages?

roomote bot requested review from cte, jr and mrubens as code owners August 4, 2025 15:07

github-project-automation bot added this to Roo Code Roadmap and Roo Code Roadmap Aug 4, 2025

github-project-automation bot moved this to New in Roo Code Roadmap Aug 4, 2025

github-project-automation bot moved this to Triage in Roo Code Roadmap Aug 4, 2025

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. bug Something isn't working labels Aug 4, 2025

roomote bot mentioned this pull request Aug 4, 2025

Clicking a historic task deletes it from history #6592

Open

roomote bot commented Aug 4, 2025

View reviewed changes

hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 4, 2025

daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Aug 4, 2025

hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Aug 4, 2025

daniel-lxs reviewed Aug 4, 2025

View reviewed changes

daniel-lxs approved these changes Aug 4, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 4, 2025

daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Aug 4, 2025

hannesrudolph added PR - Needs Review and removed PR - Needs Preliminary Review labels Aug 4, 2025

mrubens approved these changes Aug 21, 2025

View reviewed changes

roomote bot force-pushed the fix/issue-6592-corrupt-task-notification branch from a077f4b to 7382ddc Compare August 21, 2025 09:52

dosubot bot removed the size:XL This PR changes 500-999 lines, ignoring generated files. label Aug 21, 2025

dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 21, 2025

daniel-lxs moved this from PR [Needs Review] to PR [Changes Requested] in Roo Code Roadmap Aug 25, 2025

hannesrudolph added PR - Changes Requested and removed PR - Needs Review labels Aug 25, 2025

fix: address review comments - translate Catalan error message and ad…

f476729

…d debug logging

hannesrudolph force-pushed the fix/issue-6592-corrupt-task-notification branch from 7382ddc to f476729 Compare September 23, 2025 00:11

hannesrudolph moved this from PR [Changes Requested] to PR [Needs Review] in Roo Code Roadmap Sep 23, 2025

hannesrudolph added PR - Needs Review and removed PR - Changes Requested labels Sep 23, 2025

mrubens requested changes Sep 23, 2025

View reviewed changes

dosubot bot removed the lgtm This PR has been approved by a maintainer label Sep 23, 2025

daniel-lxs moved this from PR [Needs Review] to PR [Changes Requested] in Roo Code Roadmap Sep 26, 2025

hannesrudolph added PR - Changes Requested and removed PR - Needs Review labels Sep 26, 2025

fix: show notification when corrupt task fails to load #6659

Are you sure you want to change the base?

fix: show notification when corrupt task fails to load #6659

Conversation

roomote bot commented Aug 4, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Testing

User Experience

Uh oh!

roomote bot left a comment

Choose a reason for hiding this comment

Uh oh!

roomote bot commented Aug 4, 2025

Uh oh!

daniel-lxs Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

daniel-lxs Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

daniel-lxs commented Aug 4, 2025

Uh oh!

roomote bot commented Aug 4, 2025

Uh oh!

roomote bot commented Aug 4, 2025

Uh oh!

daniel-lxs left a comment

Choose a reason for hiding this comment

Uh oh!

mrubens commented Aug 21, 2025

Uh oh!

roomote bot commented Aug 21, 2025

Uh oh!

roomote bot commented Aug 21, 2025

Changes Made:

Testing:

Uh oh!

mrubens commented Aug 22, 2025

Uh oh!

hannesrudolph commented Sep 23, 2025

Uh oh!

mrubens left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

roomote bot commented Aug 4, 2025 •

edited by ellipsis-dev bot

Loading